Skip to content

Conversation

@farbod-farshidian
Copy link
Collaborator

@farbod-farshidian farbod-farshidian commented Nov 2, 2025

Description

This PR refactors and streamlines the environment reset and observation pipeline across the ManagerBasedEnv and related components. It also introduces consistent normalization support for processed actions and improves configuration clarity in the observation manager.

Summary of changes

  • Environment Reset Refactor
    • Introduced _reset() as a unified helper handling both randomized and state-based resets.
    • Replaced duplicated logic in reset() and reset_to() with calls to _reset().
  • RSL-RL Wrapper Simplification
    • Added ManagerBasedEnv::_get_observations().
    • Standardized observation retrieval to use _get_observations() in RslRlVecEnvWrapper.
  • Observation Manager Improvements
    • Added _EXCLUDED_CFG_KEYS class-level constant to list configuration fields skipped during term parsing.
    • Removed hardcoded lists within _prepare_terms().
  • Action Normalization
    • Added normalize_processed_actions() to the ActionTerm class.
    • Implemented normalization in JointAction.
    • Explicitly marked normalization as unsupported for RelativeJointPositionAction.

These changes reduce code duplication, improve consistency between reset flows, and make the action and observation interfaces cleaner and easier to extend.

Type of change

  • Refactor (non-breaking change improving internal design)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Nov 2, 2025
@farbod-farshidian farbod-farshidian changed the title Ffarshidian/refactor env reset observation normalization Refactor env reset observation normalization Nov 2, 2025
@farbod-farshidian farbod-farshidian changed the title Refactor env reset observation normalization Refactor env reset, observation, and action normalization Nov 2, 2025
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Test Results Summary

2 669 tests   2 207 ✅  2h 24m 14s ⏱️
   99 suites    461 💤
    1 files        1 ❌

For more details on these failures, see this check.

Results for commit 0b36bbd.

♻️ This comment has been updated with latest results.

@jtigue-bdai jtigue-bdai self-assigned this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants